Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for NeMoDataStore #306

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Add unit tests for NeMoDataStore #306

merged 1 commit into from
Jan 31, 2025

Conversation

shengnuo
Copy link
Collaborator

This MR introduces unit tests for the datastore controller, includes

  • CR spec validation tests
  • controller verification for datastore to ensure PVC and deployment creation

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 30, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

shivamerla
shivamerla approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@shivamerla shivamerla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please also plan to expand tests with default env injection, volume injection etc.

@shivamerla shivamerla force-pushed the datastore-controller-test branch from 48aed39 to 8cb220e Compare January 31, 2025 13:42
@shivamerla shivamerla force-pushed the datastore-controller-test branch from 8cb220e to 2f73bf1 Compare January 31, 2025 13:51
@shivamerla shivamerla merged commit 7955507 into NVIDIA:main Jan 31, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slu2011 slu2011 slu2011 approved these changes

@shivamerla shivamerla shivamerla approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@visheshtanksale visheshtanksale Awaiting requested review from visheshtanksale visheshtanksale is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shengnuo @slu2011 @shivamerla