Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project scaffolding for all microservices #308

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Fix project scaffolding for all microservices #308

merged 2 commits into from
Feb 5, 2025

Conversation

shivamerla
Copy link
Collaborator

No description provided.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 31, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shivamerla shivamerla force-pushed the fix_project_scaffolding branch from cbcb30e to 4cb6b28 Compare January 31, 2025 14:39
@shivamerla shivamerla requested review from shengnuo and varunrsekar and removed request for ArangoGutierrez January 31, 2025 17:23
@varunrsekar
Copy link
Collaborator

QQ: Do we need a separate section for update verb on <obj>/finalizers resources? The k8s-nim-operator-role RBAC in the helm chart mentions that explicitly.

@shivamerla shivamerla force-pushed the fix_project_scaffolding branch from 4cb6b28 to 1b7705f Compare February 4, 2025 02:23
@shivamerla
Copy link
Collaborator Author

QQ: Do we need a separate section for update verb on <obj>/finalizers resources? The k8s-nim-operator-role RBAC in the helm chart mentions that explicitly.

Yes, explicit permissions are required to update finalizers, as they are a subresource similar to status. Auto-generation does not include these rules by default, leading to errors without them.

mikemckiernan
mikemckiernan reviewed Feb 4, 2025
View reviewed changes
PROJECT Outdated Show resolved Hide resolved
@shivamerla
Fix project scaffolding for all microservices
c4b2570 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla
Fix rebase errors
7042290 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla shivamerla force-pushed the fix_project_scaffolding branch from def66fb to 7042290 Compare February 4, 2025 17:53
@varunrsekar
Copy link
Collaborator

QQ: Do we need a separate section for update verb on <obj>/finalizers resources? The k8s-nim-operator-role RBAC in the helm chart mentions that explicitly.

Yes, explicit permissions are required to update finalizers, as they are a subresource similar to status. Auto-generation does not include these rules by default, leading to errors without them.

I was confused because I don't see the RBAC for finalizers in this PR. Is that expected?

@shivamerla
Copy link
Collaborator Author

QQ: Do we need a separate section for update verb on <obj>/finalizers resources? The k8s-nim-operator-role RBAC in the helm chart mentions that explicitly.

Yes, explicit permissions are required to update finalizers, as they are a subresource similar to status. Auto-generation does not include these rules by default, leading to errors without them.

I was confused because I don't see the RBAC for finalizers in this PR. Is that expected?

These are already auto-generated and in the config/rbac/role.yaml here. The editor/viewer roles doesn't include them.

mkhaas
mkhaas reviewed Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@mkhaas mkhaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunrsekar
Copy link
Collaborator

LGTM

visheshtanksale
visheshtanksale approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@visheshtanksale visheshtanksale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivamerla shivamerla merged commit f7d09eb into NVIDIA:main Feb 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkhaas mkhaas mkhaas left review comments

@mikemckiernan mikemckiernan mikemckiernan left review comments

@slu2011 slu2011 slu2011 approved these changes

@visheshtanksale visheshtanksale visheshtanksale approved these changes

@shengnuo shengnuo Awaiting requested review from shengnuo

@varunrsekar varunrsekar Awaiting requested review from varunrsekar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shivamerla @varunrsekar @slu2011 @mkhaas @visheshtanksale @mikemckiernan