Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update the status value strings of nim cache and nim services #47

Merged
merged 1 commit into from
Aug 13, 2024
Merged

chore: update the status value strings of nim cache and nim services #47

merged 1 commit into from
Aug 13, 2024

Conversation

slu2011
Copy link
Collaborator

@slu2011 slu2011 commented Aug 12, 2024

No description provided.

@slu2011 slu2011 self-assigned this Aug 12, 2024
@slu2011 slu2011 requested a review from mikemckiernan August 12, 2024 20:36
mikemckiernan
mikemckiernan reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that really all there is to it? I chickened out because I noticed some more complicated work in https://github.com/NVIDIA/k8s-nim-operator/blob/main/internal/conditions/conditions.go.

@slu2011
Copy link
Collaborator Author

slu2011 commented Aug 12, 2024

Is that really all there is to it? I chickened out because I noticed some more complicated work in https://github.com/NVIDIA/k8s-nim-operator/blob/main/internal/conditions/conditions.go.

I believe conditions.go is all good (status values consistent with k8s api). Just updating the status value strings of nimcache / nimservices should be enough to fix the issue.

@slu2011 slu2011 closed this Aug 12, 2024
@slu2011 slu2011 reopened this Aug 12, 2024
@visheshtanksale visheshtanksale merged commit a2b6069 into main Aug 13, 2024
6 checks passed
@mikemckiernan
Copy link
Member

Is that really all there is to it? I chickened out because I noticed some more complicated work in https://github.com/NVIDIA/k8s-nim-operator/blob/main/internal/conditions/conditions.go.

I believe conditions.go is all good (status values consistent with k8s api). Just updating the status value strings of nimcache / nimservices should be enough to fix the issue.

Delightful! So sorry that I was cowardly. :)

@shivamerla shivamerla deleted the status branch September 27, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemckiernan mikemckiernan mikemckiernan left review comments

@visheshtanksale visheshtanksale visheshtanksale approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@shivamerla shivamerla Awaiting requested review from shivamerla shivamerla is a code owner

Assignees

@slu2011 slu2011

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slu2011 @mikemckiernan @visheshtanksale