Extract NIM model manifest in all cases for model caching #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamerla
requested review from
ArangoGutierrez,
slu2011 and
visheshtanksale
as code owners
shivamerla
force-pushed
the
fix_model_manifest_config
branch
2 times, most recently
from
bd56bab to
7f4f7a2
Compare
Signed-off-by: Shiva Krishna, Merla <[email protected]>
Signed-off-by: Shiva Krishna, Merla <[email protected]>
Signed-off-by: Shiva Krishna, Merla <[email protected]>
shivamerla
force-pushed
the
fix_model_manifest_config
branch
from
7f4f7a2 to
12e3447
Compare
slu2011
reviewed
Aug 21, 2024
|
|
||
| // Extract manifest file | ||
| output, err := r.getPodLogs(ctx, existingPod) |
There was a problem hiding this comment.
For model manifests -- do we have plan to add NGC api (or any other web apis) to query model metadata?
There was a problem hiding this comment.
pull an image and cat a file inside looks very hacky......
There was a problem hiding this comment.
that is not planned in the near term. The manifest is embedded in the NIM container itself. So we need to run the container to get that (either by cp or logging)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.