Fix nvidia-cdi-refresh systemd packaging#1827
Open
elezar wants to merge 1 commit into
Open
Conversation
elezar
force-pushed
the
fix-cdi-refresh-systemd-packaging
branch
3 times, most recently
from
d476654 to
7bd9cf2
Compare
Coverage Report for CI Build 25912014995Coverage remained the same at 43.342%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
fix-cdi-refresh-systemd-packaging
branch
from
7bd9cf2 to
c29c81f
Compare
cdesiniotis
approved these changes
May 26, 2026
Contributor
cdesiniotis
left a comment
cdesiniotis
left a comment
There was a problem hiding this comment.
Thanks @elezar. Overall lgtm, left some general questions.
Comment on lines
+25
to
+29
| %if 0%{?rhel} == 7 || 0%{?amzn} == 2 | ||
| BuildRequires: systemd | ||
| %else | ||
| BuildRequires: systemd-rpm-macros | ||
| %endif |
Contributor
There was a problem hiding this comment.
Question -- these are build-time constraints that only apply when building the RPM packages, correct?
Comment on lines
+111
to
+112
| systemctl start nvidia-cdi-refresh.path >/dev/null 2>&1 || : | ||
| systemctl start nvidia-cdi-refresh.service >/dev/null 2>&1 || : |
Contributor
There was a problem hiding this comment.
Question -- what's the rationale behind not running systemctl enabled --now anymore before this? Is it because our systemd service always gets enabled upon installation (due to the newly added .preset file)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the installation and configuration of the
nvidia-cdi-refreshsystemd units. This should address issues when installing the packages on non-running systems (e.g. during machine image builds).Changes made using Codex.