Check for valid paths in create-symlinks hook #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klueska
reviewed
Sep 18, 2024
Comment on lines
224
to
225
| resolvedParent, err := tryResolveLink(filepath.Dir(path)) | ||
| return filepath.Join(resolvedParent, filepath.Base(path)), err |
There was a problem hiding this comment.
let's put an if/else here and return "" if there is an error
klueska
reviewed
Sep 18, 2024
klueska
previously requested changes
Sep 18, 2024
This change updates the create-symlinks hook to check whether link paths resolve in the container's filesystem. In addition the executable is updated to return an error if a link could not be created. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
check-link-resolution
branch
from
c52d44e to
e383b75
Compare
cdesiniotis
approved these changes
Sep 18, 2024
elezar
added a commit
to elezar/nvidia-container-toolkit
that referenced
this pull request
Sep 20, 2024
This reverts commit c490baa, reversing changes made to 32486cf. Signed-off-by: Evan Lezar <[email protected]>
elezar
added a commit
that referenced
this pull request
Sep 20, 2024
Revert "Merge pull request #696 from elezar/check-link-resolution"
Alokbpandey
pushed a commit
to Alokbpandey/nvidia-container-toolkit
that referenced
this pull request
Jul 14, 2025
This reverts commit c490baa, reversing changes made to 32486cf. Signed-off-by: Evan Lezar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the create-symlinks hook to check whether link paths resolve in the container's filesystem. In addition the executable is updated to return an error if a link could not be created.