Skip to content

Conversation

@elezar
Copy link
Member

@elezar elezar commented Sep 26, 2024

Since we expect .so.1 symlinks to be created by ldconfig, we don't explicitly request these. This change removes the creation of a libnvidia-allocator.so.1 -> libnvidia-allocator.so.RM_VERSION symlink through the create-symlinks hook.

Since we expect .so.1 symlinks to be created by ldconfig, we don't
explicitly request these. This change removes the creation of
a libnvidia-allocator.so.1 -> libnvidia-allocator.so.RM_VERSION symlink
through the create-symlinks hook.

Signed-off-by: Evan Lezar <[email protected]>
@elezar elezar self-assigned this Sep 26, 2024
@cdesiniotis
Copy link
Contributor

Question -- does the ordering of hooks in the CDI spec file determine their execution order? E.g. if the update-ldcache hooks comes before the create-symlinks hook in the CDI spec, does the update-ldcache hook always run first?

@elezar
Copy link
Member Author

elezar commented Sep 27, 2024

Question -- does the ordering of hooks in the CDI spec file determine their execution order? E.g. if the update-ldcache hooks comes before the create-symlinks hook in the CDI spec, does the update-ldcache hook always run first?

Yes, I believe that the OCI spec guarantees the order of execution.

Hooks allow users to specify programs to run before or after various lifecycle events. Hooks MUST be called in the listed order.

Note that the Hook lifecycle also affects ordering. A createContainer hook will always run before a startContainer hook regardless of whether it's listed later in the spec.

@elezar elezar added the must-backport The changes in PR need to be backported to at least one stable release branch. label Sep 30, 2024
@elezar
Copy link
Member Author

elezar commented Sep 30, 2024

These changes should be backported to release-1.16.

@elezar elezar merged commit 006aebf into NVIDIA:main Sep 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

must-backport The changes in PR need to be backported to at least one stable release branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants