Allow IMEX channel requests by volume mount #740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
imex-by-volume-mount
branch
from
47ebbe5 to
bac3e25
Compare
tariq1890
reviewed
Oct 14, 2024
klueska
reviewed
Oct 15, 2024
klueska
reviewed
Oct 15, 2024
klueska
reviewed
Oct 15, 2024
elezar
force-pushed
the
imex-by-volume-mount
branch
from
bac3e25 to
b05b68c
Compare
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
This change allows IMEX channels to be requested using the
volume mount mechanism.
A mount from /dev/null to /var/run/nvidia-container-devices/imex/{{ .ChannelID }}
is equivalent to including {{ .ChannelID }} in the NVIDIA_IMEX_CHANNELS
envvironment variables.
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
imex-by-volume-mount
branch
from
b05b68c to
2e6712d
Compare
klueska
reviewed
Oct 17, 2024
Comment on lines
-123
to
+133
| if len(nvidia.Devices) > 0 { | ||
| args = append(args, fmt.Sprintf("--device=%s", nvidia.Devices)) | ||
| if devicesString := strings.Join(nvidia.Devices, ","); len(devicesString) > 0 { | ||
| args = append(args, fmt.Sprintf("--device=%s", devicesString)) | ||
| } | ||
| if len(nvidia.MigConfigDevices) > 0 { | ||
| args = append(args, fmt.Sprintf("--mig-config=%s", nvidia.MigConfigDevices)) | ||
| } | ||
| if len(nvidia.MigMonitorDevices) > 0 { | ||
| args = append(args, fmt.Sprintf("--mig-monitor=%s", nvidia.MigMonitorDevices)) | ||
| } | ||
| if len(nvidia.ImexChannels) > 0 { | ||
| args = append(args, fmt.Sprintf("--imex-channel=%s", nvidia.ImexChannels)) | ||
| if imexString := strings.Join(nvidia.ImexChannels, ","); len(imexString) > 0 { | ||
| args = append(args, fmt.Sprintf("--imex-channel=%s", imexString)) |
There was a problem hiding this comment.
Minor comment -- not worth fixing in this PR -- but it would be nice to keep all of these consistent -- MigConfigDevices and MigMonitorDevices are still just strings rather than a list it looks like...
There was a problem hiding this comment.
Yes. I will update in a follow-up.
klueska
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows IMEX channels to be requested as volume mounts in addition to the
NVIDIA_IMEX_CHANNELSenvironment variable.See NVIDIA/k8s-device-plugin#985 where this is used in the NVIDIA Device Plugin when the
deviceListStrategyis set tovolume-mounts.