Skip to content

Add CUDA forward compatibility hook #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 28, 2025
Merged

Add CUDA forward compatibility hook #948

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
76040ff
Add enable-cuda-compat hook to allow compat libs to be discovered
elezar Feb 6, 2025
e1ae57e
Add enable-cuda-compat hook if required
elezar Feb 6, 2025
f445d4b
Add ldconfig hook in legacy mode
elezar Feb 9, 2025
e330a93
Add enable-cuda-compat hook to CDI spec generation
elezar Feb 6, 2025
9f611a5
Ensure that mode hook is executed last
elezar Feb 9, 2025
c1bac28
Add disable-cuda-compat-lib-hook feature flag
elezar Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/runtime/runtime_factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ func supportedModifierTypes(mode string) []string {
return []string{"nvidia-hook-remover", "mode"}
case "csv":
// For CSV mode we support mode and feature-gated modification.
return []string{"nvidia-hook-remover", "mode", "feature-gated"}
return []string{"nvidia-hook-remover", "feature-gated", "mode"}
default:
return []string{"mode", "graphics", "feature-gated"}
return []string{"feature-gated", "graphics", "mode"}
Copy link

@luodw luodw May 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elezar Hi, I have a question here. In this modifier order, it will create CreateContainer Hook like this ["enable-cuda-compat", "update-ldcache", "create-symlinks"]. As "update-ldcache" runs before "create-symlinks", so hook "create-symlinks" do some bind mount so(dynamic link library) in container will not add into ldcache?

}
}