Fix device migration for Sionna PHY module state#1168
Open
DogWY wants to merge 1 commit into
Open
Conversation
Signed-off-by: DogWY <wangyan04221@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1167
Description
This PR fixes device migration behavior for
sionna.phymodules that keep logical device state, cached tensors, or precomputed tensor state outside PyTorch's normal parameter/buffer migration path.Previously, after constructing a PHY module on CPU and then calling
.to(cuda_device), some internal state could remain on the original device. This could leaveObject.devicestale, keep cached tensors on the wrong device, or produce CPU outputs for CUDA inputs in affected modules.The fix makes device-dependent internal state follow PyTorch module migration semantics while preserving trainable
torch.nn.Parameterinputs where applicable.Changes
Object.devicefrom a non-persistent_device_refbuffer instead of a plain string field.Trellisinto atorch.nn.Moduleso its transition tensors participate in.to(...)migration.Parameterinputs for custom constellation points, filter coefficients, and window coefficients.Tests
git diff --check main..HEAD3901 passed, 34 skipped, 40 warnings in 6:32:37