Replace usage of find & findIndex with other methods to support IE & PhantomJS - #88
Open
MasterCassim wants to merge 4 commits into
Open
Replace usage of find & findIndex with other methods to support IE & PhantomJS#88MasterCassim wants to merge 4 commits into
MasterCassim wants to merge 4 commits into
Conversation
Collaborator
|
Hi @MasterCassim, why have you reverted changes in |
Author
|
I reverted these changes because they were on classes which support the find; I have incorrectly modified the calls. |
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 94.58% 94.45% -0.13%
==========================================
Files 35 35
Lines 609 613 +4
Branches 69 70 +1
==========================================
+ Hits 576 579 +3
- Misses 24 25 +1
Partials 9 9
Continue to review full report at Codecov.
|
Author
|
Any progress? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After debugging quite a while I have noticed that the mocking does not work with IE & PhantomJS unless there is a polyfill for find and findIndex. I have replaced the occurrences with other methods supported in all browsers.