Skip to content

Replace usage of find & findIndex with other methods to support IE & PhantomJS - #88

Open
MasterCassim wants to merge 4 commits into
NagRock:masterfrom
MasterCassim:master
Open

Replace usage of find & findIndex with other methods to support IE & PhantomJS#88
MasterCassim wants to merge 4 commits into
NagRock:masterfrom
MasterCassim:master

Conversation

@MasterCassim

Copy link
Copy Markdown

After debugging quite a while I have noticed that the mocking does not work with IE & PhantomJS unless there is a polyfill for find and findIndex. I have replaced the occurrences with other methods supported in all browsers.

@bendykowski

Copy link
Copy Markdown
Collaborator

Hi @MasterCassim, why have you reverted changes in Mock.ts? We need to discuss that with @NagRock, I think a nicer solution would be to introduce required polyfills.

@MasterCassim

Copy link
Copy Markdown
Author

I reverted these changes because they were on classes which support the find; I have incorrectly modified the calls.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #88 into master will decrease coverage by 0.12%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   94.58%   94.45%   -0.13%     
==========================================
  Files          35       35              
  Lines         609      613       +4     
  Branches       69       70       +1     
==========================================
+ Hits          576      579       +3     
- Misses         24       25       +1     
  Partials        9        9
Impacted Files Coverage Δ
src/MethodStubCollection.ts 96.55% <85.71%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba5997f...f21c114. Read the comment docs.

@MasterCassim

Copy link
Copy Markdown
Author

Any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants