Skip to content

Conversation

@lixiangk1
Copy link
Collaborator

@lixiangk1 lixiangk1 commented Dec 5, 2024

Change hybrid GHP workflow from (1) running a 2-year simulation to guess if an auxiliary heating or cooling unit is required and outputting results to (2) running non-hybrid first in all hybrid runs and comparing to hybrid outputs to guarantee an actual hybrid solution where possible

fy25_ghp_updates.pdf

@lixiangk1 lixiangk1 requested a review from atpham88 December 5, 2024 00:40
@lixiangk1
Copy link
Collaborator Author

lixiangk1 commented Dec 5, 2024

@atpham88 Somewhat but not completely related, when I was testing this, I came across a case where if I selected "Heater", REopt produced a reasonable hybrid result, but if I selected "Cooler" ("Automatic" also selects a cooler in this case), REopt exited out of GhpGhx.jl after hitting the max number of iterations with some ridiculous result of 16,000 boreholes cause it didn't converge. GHP.ghpghx_chosen_outputs returned an empty dictionary. Which might be what's messing up the webtool outputs? What would be the ideal behavior in this case? Do we want to throw an error message whenever we hit max iterations because that most likely indicates a convergence issue and just return a non-hybrid result?

@atpham88
Copy link
Collaborator

@atpham88 Somewhat but not completely related, when I was testing this, I came across a case where if I selected "Heater", REopt produced a reasonable hybrid result, but if I selected "Cooler" ("Automatic" also selects a cooler in this case), REopt exited out of GhpGhx.jl after hitting the max number of iterations with some ridiculous result of 16,000 boreholes cause it didn't converge. GHP.ghpghx_chosen_outputs returned an empty dictionary. Which might be what's messing up the webtool outputs? What would be the ideal behavior in this case? Do we want to throw an error message whenever we hit max iterations because that most likely indicates a convergence issue and just return a non-hybrid result?

I tested with "Cooler" and had the same issue (borehole number is 67,575). But when I tested "Heater" and got the same number of boreholes as the no hybrid case. Does it mean, "Heater" is the wrong guess in this case? Let's chat more in our meeting today.

@lixiangk1
Copy link
Collaborator Author

@Bill-Becker Would you have time to review this PR before the end of FY? I'm attaching a graphic for the hybrid GHP changes we're trying to push and we can also discuss at the Development Team Tag Up
fy25_ghp_updates.pdf

Copy link
Collaborator

@Bill-Becker Bill-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a TODO comment that we can punt on for now. Can you add a GitHub Issue for that?

@lixiangk1 lixiangk1 merged commit 9d44f35 into develop Sep 27, 2025
3 checks passed
@lixiangk1 lixiangk1 deleted the ghp-select-hybrid-aux-unit branch September 27, 2025 00:14
This was referenced Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants