Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1585 errors reported by axe accessibility tests must be fixed #1587

Conversation

miguelvaara
Copy link
Contributor

Reasons for creating this PR

This is just the beginning of the Draft PR and at this point the intention is not to complete the information requested in the PR template. The goal now is only to make the code more easily viewable for other developers. Detailed information will be provided later!

Link to relevant issue(s), if any

  • Closes #

Description of the changes in this PR

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@miguelvaara miguelvaara requested a review from osma January 30, 2024 11:28
@miguelvaara miguelvaara self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e049d3) 70.54% compared to head (31123a8) 70.54%.
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1587   +/-   ##
=========================================
  Coverage     70.54%   70.54%           
  Complexity     1644     1644           
=========================================
  Files            32       32           
  Lines          4315     4315           
=========================================
  Hits           3044     3044           
  Misses         1271     1271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@miguelvaara miguelvaara removed the request for review from osma February 1, 2024 11:09
@miguelvaara
Copy link
Contributor Author

This is not needed anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant