Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Twig 3.8 #1588

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Upgrade to Twig 3.8 #1588

merged 1 commit into from
Feb 1, 2024

Conversation

osma
Copy link
Member

@osma osma commented Jan 31, 2024

Reasons for creating this PR

Getting rid of EOL'd Twig 2.

Link to relevant issue(s), if any

Description of the changes in this PR

  • bump Twig dependency to 3.8.*
  • adjust to API changes (in PHP code) between Twig 2 and 3

No Twig templates were harmed when performing this upgrade. (In other words, the templates themselves are unchanged.)

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added the maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance label Jan 31, 2024
@osma osma added this to the 3.0 milestone Jan 31, 2024
@osma osma self-assigned this Jan 31, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (d0aa524) 70.54% compared to head (5b4b419) 70.54%.
Report is 8 commits behind head on main.

Files Patch % Lines
src/controller/WebController.php 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1588   +/-   ##
=========================================
  Coverage     70.54%   70.54%           
  Complexity     1644     1644           
=========================================
  Files            32       32           
  Lines          4315     4315           
=========================================
  Hits           3044     3044           
  Misses         1271     1271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osma osma merged commit 2c0a8f7 into main Feb 1, 2024
11 of 12 checks passed
@osma osma deleted the issue1585-upgrade-twig-3 branch February 1, 2024 07:47
@osma osma modified the milestones: 3.x, 3.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

Upgrade to Twig 3 for Skosmos 3
1 participant