Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a troublesome comment line #1592

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Removed a troublesome comment line #1592

merged 1 commit into from
Feb 1, 2024

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Feb 1, 2024

Reasons for creating this PR

A bug was found with partial page loading during development.

Description of the changes in this PR

Ramoved a doulbe slash comment line that was breaking JSON parsing. Added a html comment tag that warns about such.

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@joelit joelit requested a review from osma February 1, 2024 10:57
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joelit joelit merged commit cf80dfa into main Feb 1, 2024
9 of 10 checks passed
@joelit joelit deleted the skosmos-3-scripts-hotfix branch February 1, 2024 10:59
@osma osma added the bug label Feb 1, 2024
@osma osma added this to the 3.0 milestone Feb 1, 2024
@osma osma modified the milestones: 3.x, 3.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants