Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed trailing commas from SKOSMOS object #1594

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

joelit
Copy link
Contributor

@joelit joelit commented Feb 1, 2024

Reasons for creating this PR

Further formatting of SKOSMOS object was needed for JSON parsing.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@joelit joelit added this to the 3.0 milestone Feb 1, 2024
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@osma
Copy link
Member

osma commented Feb 1, 2024

I think we need a Cypress test to catch these kinds of problems.

@joelit joelit merged commit 83fd8a1 into main Feb 1, 2024
8 of 10 checks passed
@joelit joelit deleted the skosmos-3-scripts-hotfix2 branch February 1, 2024 12:41
@osma osma modified the milestones: 3.x, 3.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants