Skip to content

adjust deprecated alert box: no bottom margin - #2026

Merged
osma merged 1 commit into
mainfrom
adjust-deprecated-alert-margin
Jun 3, 2026
Merged

adjust deprecated alert box: no bottom margin#2026
osma merged 1 commit into
mainfrom
adjust-deprecated-alert-margin

Conversation

@osma

@osma osma commented Jun 2, 2026

Copy link
Copy Markdown
Member

Reasons for creating this PR

We agreed today (at the Finto weekly meeting) that alert boxes for deprecated concepts and vocab messages look better when the box is directly adjacent to the main content box. This PR implements the minor CSS adjustment for deprecated concept warnings.

Link to relevant issue(s), if any

Description of the changes in this PR

Remove the margin-bottom of the deprecated alert so it looks like this (notice no grey border between red and white areas):

image

Known problems or uncertainties in this PR

Bloats the CSS by one more line. I couldn't think of a cleaner solution...

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.42%. Comparing base (19f8723) to head (e764b4c).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2026   +/-   ##
=========================================
  Coverage     70.42%   70.42%           
  Complexity     1703     1703           
=========================================
  Files            34       34           
  Lines          4436     4436           
=========================================
  Hits           3124     3124           
  Misses         1312     1312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@osma osma self-assigned this Jun 2, 2026
@osma osma added this to the 3.3 milestone Jun 2, 2026
@osma
osma merged commit 893292b into main Jun 3, 2026
19 checks passed
@osma
osma deleted the adjust-deprecated-alert-margin branch June 3, 2026 07:19
@github-project-automation github-project-automation Bot moved this to Issue/PR closed in Skosmos 3.x Backlog Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Issue/PR closed

Development

Successfully merging this pull request may close these issues.

1 participant