Skip to content

Fix switching between sidebar tabs using the keybaord - #2029

Merged
UnniKohonen merged 1 commit into
mainfrom
fix-switching-between-sidebar-tabs
Jun 4, 2026
Merged

Fix switching between sidebar tabs using the keybaord#2029
UnniKohonen merged 1 commit into
mainfrom
fix-switching-between-sidebar-tabs

Conversation

@UnniKohonen

Copy link
Copy Markdown
Contributor

Reasons for creating this PR

Switching between sidebar tabs using the arrow keys does not currently load the contents of the tabs. This PR fixes the way tab contents are loaded. Contents should now be loaded when tabs are clicked and when switching between them with arrow keys.

Description of the changes in this PR

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@UnniKohonen UnniKohonen added this to the 3.3 milestone Jun 4, 2026
@UnniKohonen UnniKohonen self-assigned this Jun 4, 2026
@UnniKohonen UnniKohonen added the bug label Jun 4, 2026
@UnniKohonen UnniKohonen moved this to Under review in Skosmos 3.x Backlog Jun 4, 2026
@UnniKohonen
UnniKohonen requested a review from osma June 4, 2026 13:06
@qltysh

qltysh Bot commented Jun 4, 2026

Copy link
Copy Markdown

2 new issues

Tool Category Rule Count
qlty Structure Function with many returns (count = 12): startGroupsApp 2

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.42%. Comparing base (527659b) to head (c83eb87).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2029   +/-   ##
=========================================
  Coverage     70.42%   70.42%           
  Complexity     1703     1703           
=========================================
  Files            34       34           
  Lines          4436     4436           
=========================================
  Hits           3124     3124           
  Misses         1312     1312           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@osma osma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks sane and works perfectly (tested under Firefox and Chromium).

@UnniKohonen
UnniKohonen merged commit 24f8bfb into main Jun 4, 2026
15 of 19 checks passed
@github-project-automation github-project-automation Bot moved this from Under review to Issue/PR closed in Skosmos 3.x Backlog Jun 4, 2026
@osma
osma deleted the fix-switching-between-sidebar-tabs branch June 4, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Issue/PR closed

Development

Successfully merging this pull request may close these issues.

2 participants