Skip to content

Added Vue i18n dependency - #2031

Merged
osma merged 1 commit into
mainfrom
issue2030-add-Vue-i18n-dependency
Jun 9, 2026
Merged

Added Vue i18n dependency#2031
osma merged 1 commit into
mainfrom
issue2030-add-Vue-i18n-dependency

Conversation

@Vainonen

@Vainonen Vainonen commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Reasons for creating this PR

Link to relevant issue(s), if any

Description of the changes in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.42%. Comparing base (24f8bfb) to head (57f3d8f).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2031   +/-   ##
=========================================
  Coverage     70.42%   70.42%           
  Complexity     1703     1703           
=========================================
  Files            34       34           
  Lines          4436     4436           
=========================================
  Hits           3124     3124           
  Misses         1312     1312           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@osma osma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osma osma assigned osma and Vainonen and unassigned osma Jun 9, 2026
@osma osma added the maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance label Jun 9, 2026
@osma osma moved this to Under review in Skosmos 3.x Backlog Jun 9, 2026
@osma osma added this to the 3.3 milestone Jun 9, 2026
@osma
osma merged commit 0ae1c6f into main Jun 9, 2026
18 of 19 checks passed
@github-project-automation github-project-automation Bot moved this from Under review to Issue/PR closed in Skosmos 3.x Backlog Jun 9, 2026
@osma
osma deleted the issue2030-add-Vue-i18n-dependency branch June 9, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Dependency changes, security updates, infrastructure tweaks & general mainenance

Projects

Status: Issue/PR closed

Development

Successfully merging this pull request may close these issues.

Add Vue i18n dependency

2 participants