EKIRJASTO-88 Add selected books

[natlibfi-burger]

What's this do?
This code adds the possibility for a user to add and remove books from a list of favorites. to both single book view and list views a button is added from which the adding and removing a book from favorites. Successfully adding a book creates a toast telling the user about successful adding or removal of a book from favorites.

The favorites are shown on their own tab, Favorites, while loans and reserves are moved under one tab, My books. In the future, The favorites page can be expanded upon when more lists are added. The loans and reserves in the same view are differentiated with the same kind of tab than audiobook-ebook-all in the catalog. All books have also a new field called selected. This information is used to show different buttons based on if book is selected as a favorite or not.

As opposed to the old solution where we get the data only from the loans feed, we now have another feed that carries the information of selected books. These feed entries are combined and stored to the database and register. It is planned that all other information we need to add (like information if a book is read, or is graded) is added to the selected feed.

Handling the adding and removing of favorites is handled similarly to the handling of the loan limit reached -popup. Two book statuses have been added, selected and unselected, that trigger the wanted handling for both the behaviours, respectively. The book does not spend a long time in this state, instead, the old state is reset when the book information has been updated to the database and the register, as well as the popup has been shown. To note: This can cause possible audio descriptors to call out incorrect information, as the status is reset.

The code also handles 401 refreshes, both on select and unselect. If a user is not logged in and they attempt to select/unselect a book, it shows the login screen.

Old translations need to be adjusted. Lainat -> Omat kirjat (ex).

Why are we doing this? (w/ JIRA link if applicable)
https://jira.it.helsinki.fi/browse/EKIRJASTO-88

How should this be tested? / Do these changes have associated tests?
The code can be tested by logging in and going to catalog, and adding books to the list. There should be a popup informing the user of what book has been added or removed. The added books should be seen on their own tab "Favorites" tab on the bottom tab bar. Removing books from the list should refresh the list, so that the information remains fresh. If not logged in, the My books tab should show tabs even when not logged in, and there should be a text suggesting logging in. A new text is also added to favorites page. When logged in and there is no favorites, there should be a text informing how to add books from catalog into the list.

If logged out and trying to select a book, the login page should open.

The books should also be able to be added from the single book view, with a toast popping up there as well.

Refresh can be tested by logging in and waiting 10 min, and then trying to select or unselect a book.

Dependencies for merging? Releasing to production?
Should not be released before also done in IOS.

Does this require updates to old Transifex strings? Have the translators been informed?
In its current form, this does require updates to old strings. There is also new strings.

• Have informed translators

[NatLibFi-JoonaKupe]

The use of sets and maps in booksynctasks for tracking IDs and entries should provide efficient lookups and insertions, which is important when handling potentially large numbers of books and feed entries.
Some of the database and feed processing could also be refactored into separate methods or classes to improve readability and maintainability is just a little something to think about for future use, but as it already is somewhat spread around, we'll just need to keep this in mind.

The code covers set of functionalities required to handle multiple book feeds in a way I kinda like here. Good practices in error handling and logging.

Did not try to run the code. Only code review done. Should this be presented to our feedback group for comments before merging?

[natlibfi-ptalosel]

First notes from testing with device.

• Both loans list and holds list show the same text if lists are empty. Text is either "Jos sinulla on varauksia" or the "Lainauksesi näytetään täällä". Holds list should show the holds text and vice versa.
• It is hard to tap the Select button in any book view, as the button is quite small (or the button has small target area)
• In Favorites list the button with Finnish text "Poista" can be misleading. User might think the button removes the book from the Favorites list, but actually it is the button that returns the book. Maybe Palauta should be used instead of Poista, and also the Swedish and English translations should probably check. The button text was not previously a problem, as we had only loans and holds book lists.
• If user tries to reserve a book and there is an error (for example user has already the maximum number of books reserved), the book is displayed in loans list and not in holds list
• If the favorite list is ordered by Author, the Authors firstname is used for sorting instead of surname

Otherwise favorite functionality works as expected when testing with device. Toast notifications when adding or removing a book from favorites were nice! 👍

[natlibfi-ptalosel]

Tested with device after updates. OK!