fix major issues from sonarqube #2336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cogross
commented
Apr 3, 2024
cogross
commented
- Interrupted exceptions should be rethrown OR method should be re-interrupted (see https://cwe.mitre.org/data/definitions/391)
- Method parameters should not be used for synchronization (see MITRE, CWE-412 - Unrestricted Externally Accessible Lock | MITRE, CWE-413 - Improper Resource Locking | CERT, LCK00-J. - Use private final lock objects to synchronize classes that may interact with untrusted code)
- Synchronization should be done on instances of value-based classes (see http://localhost:9000/coding_rules?open=java%3AS1860&rule_key=java%3AS1860)
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
3 times, most recently
from
dd6a584 to
119a61e
Compare
sparkyy34
previously approved these changes
Apr 5, 2024
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
119a61e to
815fa66
Compare
cogross
changed the title
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
5 times, most recently
from
282a3e6 to
b1cfb9c
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
3 times, most recently
from
6104721 to
b56572c
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
5 times, most recently
from
a20f5dc to
55f7e84
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
2 times, most recently
from
ff4f110 to
266af42
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
266af42 to
cd16335
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
cd16335 to
8cf51c2
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
2 times, most recently
from
8b5c522 to
0d8bd4c
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
2 times, most recently
from
d10d93a to
6d4d795
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
6d4d795 to
844ad59
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
2 times, most recently
from
961818f to
6e35f3d
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
4 times, most recently
from
5a2d85d to
0ab2f86
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
3 times, most recently
from
1686043 to
8d92010
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
8d92010 to
1527ba8
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
1527ba8 to
a63382a
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
4 times, most recently
from
7137712 to
81589bb
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
5 times, most recently
from
b6f462a to
d5a03d4
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
4 times, most recently
from
37da6fd to
6d6370d
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
3 times, most recently
from
45c979c to
bd57eae
Compare
cogross
force-pushed
the
2321-fix-major-issues-sq
branch
from
bd57eae to
4eb4c99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.