Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Laravel 12.x & PHP 8.4 #166

Merged
merged 15 commits into from
Feb 25, 2025
Merged

Support Laravel 12.x & PHP 8.4 #166

merged 15 commits into from
Feb 25, 2025

Conversation

SRWieZ
Copy link
Member

@SRWieZ SRWieZ commented Feb 17, 2025

Replaces #165

  • Support Laravel 12 & PHP 8.4
  • Refactored to group feature and unit tests separately, so we can work on E2E tests separately
    • Added MacOS to unit tests
    • Isolated BootingTest into his own workflow

More details in the comment below.

Depends on:

@SRWieZ SRWieZ changed the title L12 compatibility Laravel 12.x Compatibility Feb 17, 2025
@SRWieZ SRWieZ marked this pull request as draft February 17, 2025 12:09
@SRWieZ SRWieZ changed the title Laravel 12.x Compatibility Support Laravel 12.x & PHP 8.4 Feb 24, 2025
@SRWieZ SRWieZ marked this pull request as ready for review February 24, 2025 19:08
@SRWieZ
Copy link
Member Author

SRWieZ commented Feb 24, 2025

I took this opportunity to try to fix the test suite, but I didn't really succeed.

  • It still fails on Ubuntu, I believe since GitHub Actions updated Ubuntu 24.04.
  • It seems to fail on prefer-lowest in L11 and L12.

The BootingTest is a bit blurry, we don't have any information on why it fails.That's why I isolated it into another workflow for now. It's still running but in ideal conditions. I intend to look at this in a separate PR.

At least now we have 74 ✅ PHP tests workflows.

Of course, there is still the plugin test failing that I will fix next in #154.

@SRWieZ SRWieZ merged commit eac69c2 into main Feb 25, 2025
75 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants