Skip to content

fix(ivy): support view references in insertBefore #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

When using ViewEngine, insertBefore is always called with the result of nextSibling. On Ivy this has changed so the View itself is returned. The current implementation will ignore view order when running with ivy

What is the new behavior?

Support view references to be passed to insertBefore, fixing positioning issues.

Fixes #2176 #2249.

@cla-bot cla-bot bot added the cla: yes label Sep 20, 2020
@NathanWalker NathanWalker merged commit c2eaef5 into NativeScript:master Sep 21, 2020
@bellalMohamed
Copy link
Contributor

Great work 👌👌👌
Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 9: Using ngIf changes order of children inside a StackLayout
3 participants