Small patch CLI list of items (fixes ignoring some files; also corrects limit, as expected, so then PAGE_SIZE will be *size*) #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…index), also now it returns proper count of items (as expected?) (PAGE_SIZE items, not PAGE_SIZE+1)
Owner
|
Thanks! Can you include a test for this PR? |
Author
Added, I hope it helps you |
Author
|
(@Nekmo don't know if I need to mention but maybe you have not seen it) |
Owner
|
Thanks, I hadn't seen the comment :) I will add it to the next version |
|
I just wanted to say buddy @vitalkrilov thank you so much... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ignoring files in CLI list (every file at limit+2 index), also now it returns proper count of items (as expected?) (PAGE_SIZE items, not PAGE_SIZE+1)