ci: declare read-all permissions on the kubernetes and card-build test workflows#3198
ci: declare read-all permissions on the kubernetes and card-build test workflows#3198arpitjain099 wants to merge 1 commit into
Conversation
full-stack-test.yml and test-card-build.yml both only check out the repo, install dependencies, and run tests against a local stack. They don't post check runs, comment on PRs, push tags, or upload artifacts that GitHub's API has to authorise. Declaring `permissions: read-all` at workflow scope brings them into line with test.yml, which already uses the same shorthand. ux-tests.yml is deliberately left for a separate change since it uses dorny/test-reporter (needs checks: write) and actions/cache, which deserve a more careful permissions story than this drive-by patch. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Greptile SummaryThis PR adds
Confidence Score: 5/5Safe to merge — the only change is adding an explicit read-only token scope to two CI workflows, with no effect on job logic. Both files receive a single, additive line that restricts the GITHUB_TOKEN to read-only permissions. Neither workflow makes GitHub API calls, so no existing functionality is broken. The placement is correct YAML for workflow-level permissions, and the value read-all matches the pattern already used in test.yml. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "ci: declare read-all permissions on the ..." | Re-trigger Greptile |
Two test workflows currently don't declare a
permissions:block, so they inherit whatever scope the repo's default grants the workflowGITHUB_TOKEN:.github/workflows/full-stack-test.yml-- spins up a local minikube stack viametaflow-dev all-upand runs a tutorial flow. No GitHub API calls..github/workflows/test-card-build.yml--npm ci && npm run buildinsidemetaflow/plugins/cards/ui. No GitHub API calls.permissions: read-allat workflow scope is the same shorthandtest.ymlalready uses, so this patch keeps the style consistent. With explicit read-only scope:Token-Permissionscheck goes green for these filesI left
ux-tests.ymlout on purpose. It runsdorny/test-reporter@d61b558..., which writes check runs (checks: write), and it caches pip viaactions/cache. Both touch the permissions story in ways I'd rather pin down in a separate PR if you're interested.