Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return UNSPECIFIED filter category when not implemented by ZuulFilter #1890

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

gavinbunney
Copy link
Collaborator

@gavinbunney gavinbunney commented Feb 14, 2025

Rather than throw an exception when a category is not defined on a ZuulFilter subclass, return an UNSPECIFIED category instead. There are cases when filters are instantiated per request (like ProxyEndpoint) or in anonymous classes (like out static response handler), so this provides a better default safe-guard when the Filter annotation is not in use.

@gavinbunney gavinbunney changed the title Return unspecified filter category when not implemented by ZuulFilter Return UNSPECIFIED filter category when not implemented by ZuulFilter Feb 14, 2025
@gavinbunney gavinbunney merged commit 1b8837d into master Feb 14, 2025
5 checks passed
@gavinbunney gavinbunney deleted the gavin/unspecified-category branch February 14, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants