-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: unify API for plugin installation #401
Draft
derevnjuk
wants to merge
2
commits into
master
Choose a base branch
from
feat/unify-API-for-plugin-installation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #13 ↗︎Details:
Review all test suite changes for PR #401 ↗︎ |
28740fa
to
b33516b
Compare
Sija
reviewed
Jun 16, 2024
@@ -125,20 +129,20 @@ describe('my tests', () => { | |||
|
|||
By default, the plugin will save the generated HAR file to the root of your project with a file name that includes the current spec's name (e.g. `{specName}.har`). | |||
|
|||
You can also specify a different destination folder for the generated HAR file by setting the `CYPRESS_HARS_FOLDERS` environment variable or the `hars_folders` field in the `env` object in your Cypress config file: | |||
You can also specify a different destination folder for the generated HAR file by setting the `CYPRESS_HARS_FOLDER` environment variable or the `hars_folder` field in the `env` object in your Cypress config file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest using a singular form here:
Suggested change
You can also specify a different destination folder for the generated HAR file by setting the `CYPRESS_HARS_FOLDER` environment variable or the `hars_folder` field in the `env` object in your Cypress config file: | |
You can also specify a different destination folder for the generated HAR file by setting the `CYPRESS_HAR_FOLDER` environment variable or the `har_folder` field in the `env` object in your Cypress config file: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: enhancement
New feature or request.
Type: technical debt
Changes that remove or significantly update old unused code and/or dependencies.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.