Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repeater): adopt self-deploying repeaters #202

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

feat(repeater): adopt self-deploying repeaters #202

wants to merge 15 commits into from

Conversation

ostridm
Copy link
Contributor

@ostridm ostridm commented Jun 19, 2024

closes #201

ostridm added 15 commits May 16, 2024 17:12
@ostridm
feat(repeater): get rid of supporting web sockets
fd2e5cd 
closes #196
@ostridm
feat(repeater): replace rmq with web-sockets
589c90e 
closes #196
@ostridm
feat(repeater): address code coverage issues
7caf3ee 
closes #196
@ostridm
feat(repeater): remove accidentally committed test
7aec236 
closes #196
@ostridm
feat(repeater): address code complexity issues
52afe0c 
closes #196
@ostridm
feat(repeater): address pr comments
878e8ce 
closes #196
@ostridm
feat(repeater): address pr comments
504ebfe 
closes #196
@ostridm
feat(repeater): fix build
956b065 
closes #196
@ostridm
feat(repeater): address undefined encoding issue
5f50d9f 
closes #196
@ostridm
feat(repeater): revert RepeaterManager
26492b8 
closes #196
@ostridm
feat(repeater): eliminate 'Bus' term misuse
b738876 
closes #196
@ostridm
feat(repeater): update README
ed80f20 
closes #196
@ostridm
feat(repeater): update README
f14760c 
closes #196
@ostridm
feat(bus): get rid of amqp event bus
02aa6e4 
BREAKING CHANGE: The `sectester/bus` package, which was intended
to provide support of communication via the AMQP transport is removed.
This change simplifies the codebase by removing deprecated options and
encourages the use of more modern and supported transport methods.

closes #196
@ostridm
feat(repeater): adopt self-deploying repeaters
79b26ce 
closes #201
@ostridm ostridm force-pushed the feat_#201/adopt-self-deploying-repeaters branch from 37e9e3f to 79b26ce Compare June 19, 2024 06:48
ostridm
ostridm commented Jun 19, 2024
View reviewed changes
packages/repeater/src/lib/RepeaterFactory.ts
const container = this.configuration.container.createChildContainer();

container.register(RepeaterId, { useValue: repeaterId });
const repeaterBridgesOptions: RepeaterBridgesOptions = {
domain: this.generateName(namePrefix, disableRandomNameGeneration)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having random name generation at the client side enabled (the default behaviour) lead to uuid doubling in final repeater name at UI e.g. DOSTRIKOV-bed362e3-bd70-4fd6-b400-99db1170b-6e117491-036d-4e93-9189-f5c97726a545.

Also it eliminates No such repeater issue.

@ostridm ostridm marked this pull request as ready for review June 19, 2024 06:55
@ostridm ostridm self-assigned this Jun 19, 2024
@ostridm ostridm added the Type: enhancement New feature or request. label Jun 19, 2024
@ostridm ostridm requested a review from derevnjuk June 19, 2024 06:55
@ostridm ostridm force-pushed the feat_#196/get-rid-of-amqp-bus branch from 02aa6e4 to a307ed1 Compare June 19, 2024 13:09
Base automatically changed from feat_#196/get-rid-of-amqp-bus to master June 20, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derevnjuk derevnjuk Awaiting requested review from derevnjuk

At least 1 approving review is required to merge this pull request.

Assignees

@ostridm ostridm

Labels
Type: enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ostridm