Parse spikeglx nidq without gate or trigger number #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @guptadivyansh! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-12-12 17:31:44 UTC |
|
@alejoe91 Please do have a look, thanks! |
alejoe91
approved these changes
Jan 26, 2024
|
We should add a test to check this again the file "Noise4Sam_g0" wich has NIDQ |
alejoe91
reviewed
Jan 29, 2024
@samuelgarcia actually this only deals with nidq filenames without the gate/trigger pattern. In all our test files, the NIDQ streams are correctly loaded from the first condition (here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'easy' regex
in parse_spikeglx_fname in spikeglxraio.pyexpects the fname to end in .ap or .lf, which doesn't work if the input is actually an NIDaq file from SpikeGLX.I just added another regex that works for the .nidq files, and some example filenames to comment what the regex targets.