[refactor] Circuit Migration #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilt 를 통해 applicationContext 를 presenter 에 주입이 가능하다!
어렵다 어려워!
NavHost 를 래핑하는 전역 Scaffold 가 사라진 관계로 전체 화면들을 Scaffold 로 각각 매핑
홈 화면 Surface -> Scaffold
start destination Home -> Splash pop() -> resetRoot()
# Conflicts: # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/BandalartBottomSheet.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/HomeScreen.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/viewmodel/BottomSheetViewModel.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/viewmodel/HomeUiAction.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/viewmodel/HomeViewModel.kt
# Conflicts: # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/HomeScreen.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/ui/HomeHeader.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/ui/bandalart/BandalartEmojiBottomSheet.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/ui/bandalart/BandalartListBottomSheet.kt
circuit 을 도입하는 더 적절한 형태로 리팩토링
다시 migration 시작
CompleteViewModel 의 모든 기능을 이전
답이 없다... 너무 어렵다... 도저히 감을 못잡겠다.
다른 부분 먼저 리팩토링 이후 활성화
scope 를 필요로하는 함수마다 전부 scope 를 파라미터로 받아서 사용해야하는지 의문 CompleteScreen innerPadding 제거
HomeUI 에는 state 와 modifier 외에 다른 콜백은 파라미터로 포함시킬 수 없는 것인지 의문
Overlay 를 이용한 Result 패턴 굳이 필요없을 것 같음 기존에 사용했던 dialog, bottomSheet 가 충분히 잘 동작하고 있음
public -> private
옵션 버튼 클릭시 발생하는 이벤트가 잘못 매칭됨 showSnackbar -> showToast
presenter 내에서 직접 startActivity 를 호출할 수 없음 AndroidScreenAwareNavigator 를 통해 우회하는 방식으로 해결
AAC ViewModel ㅂㅂ2
모든 기능 migration 성공
suspend -> flow collectAsRetainedState 적용
# Conflicts: # README.md # app/src/main/kotlin/com/nexters/bandalart/ui/BandalartApp.kt # feature/complete/src/main/kotlin/com/nexters/bandalart/feature/complete/CompleteScreen.kt # feature/complete/src/main/kotlin/com/nexters/bandalart/feature/complete/viewmodel/CompleteViewModel.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/BandalartBottomSheet.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/HomeScreen.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/ui/HomeHeader.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/ui/bandalart/BandalartCell.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/ui/bandalart/BandalartDropDownMenu.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/ui/bandalart/BandalartSkeletonScreen.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/ui/bandalart/CellText.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/viewmodel/HomeUiAction.kt # feature/home/src/main/kotlin/com/nexters/bandalart/feature/home/viewmodel/HomeViewModel.kt
easyhooon
added
the
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.