hotfix: 댓글목록 조회시 AttributeConverter 예외 발생 처리 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giyeon95
approved these changes
Aug 13, 2023
|
|
||
| // TODO (larry.x) writerInfo 가 null 인 경우에 jsonStr not-nullable 이어서 | ||
| // 실패하는 문제가 있어서 임시로 처리해두었음 | ||
| if (jsonStr == null) { |
There was a problem hiding this comment.
요거를 Sentry 보고 아차 했는데..ㅎㅎ
writerInfo 필드를 not-null 로 변경했습니다! (기존 데이터도 not-null 로 변경)
There was a problem hiding this comment.
이후 예외처리가 not-null 이지만 Null을 고려해야할 것 같아서, 위 코드는 미안하지만 다시 제거해도 괜찮지 않을까 의견 드립니당!
There was a problem hiding this comment.
@giyeon95 넹넹 요거 그러면 머지 안하고 브랜치 삭제하겠읍니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.