Skip to content

Adds feature to Edit Custom certificates. #4425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rumansaleem
Copy link

@rumansaleem rumansaleem commented Mar 8, 2025

Closes #1618 & #1911

  • Adds a PUT API to update certificate data (using only nice_name for now). The method to call this API already existed in client-side.
  • Updates the existing Form UI & Logic:
    • Conditionally calls updating or creating a certificate.
    • Makes certificates non-required in case of editing
    • Existing API call to upload files to existing certificate, replaces the existing files, in case files already exists.

Screenshots

image
Edit Menu (only for custom certificates)

image
Edit Form (re-uses existing form)

@rumansaleem rumansaleem force-pushed the feature/edit-custom-certificates branch from ad1f773 to 6c9531e Compare March 8, 2025 20:43
@nginxproxymanagerci
Copy link

Docker Image for build 2 is available on
DockerHub
as nginxproxymanager/nginx-proxy-manager-dev:pr-4425

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

@rumansaleem rumansaleem marked this pull request as ready for review March 9, 2025 17:42
@rumansaleem
Copy link
Author

Hey @jc21 can you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Allow update custom existing SSL Certificate
1 participant