Skip to content

fix: optimize certbot ownership script to reduce container startup time #4491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

addievo
Copy link

@addievo addievo commented Apr 20, 2025

Replace inefficient find/execdir implementation that was causing 3+ minute startup delays with a more efficient approach that:

  1. Uses a flag file to skip redundant operations on container restarts
  2. Processes site-packages directories with bulk chown operations instead of individual file checks and changes
  3. Maintains the same functionality while dramatically improving performance

This change should significantly reduce container startup time while ensuring all necessary file permissions are still properly set.

Replace inefficient find/execdir implementation that was causing 3+ minute
startup delays with a more efficient approach that:

1. Uses a flag file to skip redundant operations on container restarts
2. Processes site-packages directories with bulk chown operations instead
   of individual file checks and changes
3. Maintains the same functionality while dramatically improving performance

This change should significantly reduce container startup time while ensuring
all necessary file permissions are still properly set.
@nginxproxymanagerci
Copy link

Docker Image for build 1 is available on
DockerHub
as nginxproxymanager/nginx-proxy-manager-dev:pr-4491

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant