chore: electron 31 #622
Merged
chore: electron 31 #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nndesign ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nndesign ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jgresham
force-pushed
the
chore/electron-31
branch
from
a709efa to
c80aa15
Compare
|
@corn-potage I don't think we should spend too much time on making this work at the moment. Just wanted to make you aware and see if there was something that I was missing. |
|
sure, sounds good! it's strange that the update affected transparency 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidebar has issues and it flashes repeatedly and devtools don't work, however, disabling background-color: 'transparent' along with the blur fixes this.
Transparent background implementation seems to have changed in Electron 31 (or the Chrome version in Electron 31+). css
background-color: 'transparent'leaves the sidebar white instead of showing the nice mac style transparency. I didn't find anything in the release docs that says the implementation changed, but on Electron's docs they note the limitations oftransparent: truewhen creating a BrowserWindow here https://www.electronjs.org/docs/latest/tutorial/window-customization#create-transparent-windowsafter disabling mac specific transparency:
