Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update package.json #689

wants to merge 1 commit into from

Conversation

tchalvak
Copy link
Member

Purpose of PR:

Things that make review take longer:

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • No comments on changed files
  • Changes to critical code (login, work-case, etc)
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a client
  • This will fix a bug

Attach Screenshot here of your change:

Preview results at the url:
(http://localhost if nowhere else)
http://localhost:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant