Skip to content

Add Lenovo ThinkPad X1 Yoga Gen 8 #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Add Lenovo ThinkPad X1 Yoga Gen 8 #1447

merged 1 commit into from
May 5, 2025

Conversation

bittner
Copy link
Contributor

@bittner bittner commented Apr 16, 2025

Convertible laptop equipped with e.g. 13th Gen Intel Core i7-1365U × 12, 32 GiB RAM, and 512 MiB or 1 TiB SSD HDD.

Description of changes

Adds a configuration, which is practically identical to the 7th-gen model.

@MayNiklas, would you mind to review?

Additional Context

1.) The model has a fingerprint reader integrated in the power button. I'm not sure whether this is already covered or I should to add the related configuration to this PR.

2.) My hardware-configuration.nix, which is derived from the one generated by the GUI installer, looks like this:

{ config, lib, modulesPath, ... }:
{
  imports = [
    (modulesPath + "/installer/scan/not-detected.nix")
  ];

  boot = {
    initrd.availableKernelModules = [ "xhci_pci" "thunderbolt" "nvme" "usb_storage" "sd_mod" ];
    initrd.kernelModules = [ ];
    kernelModules = [ "kvm-intel" ];
    extraModulePackages = [ ];
  };

  nixpkgs.hostPlatform = lib.mkDefault "x86_64-linux";
  hardware.cpu.intel.updateMicrocode = lib.mkDefault config.hardware.enableRedistributableFirmware;
  services.fwupd.enable = true;
}
Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

Copy link
Member

@MayNiklas MayNiklas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there :)

@Mic92 Mic92 marked this pull request as draft May 4, 2025 06:34
@Mic92
Copy link
Member

Mic92 commented May 4, 2025

Please undraft when you are done.

Convertible laptop equipped with e.g. 13th Gen Intel Core i7-1365U × 12, 32 GiB RAM, and 512 MiB or 1 TiB SSD HDD
@bittner bittner requested a review from MayNiklas May 4, 2025 22:11
@bittner bittner marked this pull request as ready for review May 4, 2025 22:11
@Mic92 Mic92 merged commit e128b73 into NixOS:master May 5, 2025
2 checks passed
@bittner bittner deleted the patch-1 branch May 5, 2025 09:09
@bittner
Copy link
Contributor Author

bittner commented May 5, 2025

I have a follow-up question: IIUC, the fingerprint reader and firmware updates are not enabled by default for Yoga models. Is there a good reason for this?

Would there be anything wrong with adding those two lines to the hardware configuration in this repository?

  services.fprintd.enable = lib.mkDefault true;
  services.fwupd.enable = lib.mkDefault true;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants