Add yt6801 driver for TUXEDO InfinityBook Pro 14 - Gen9 - INTEL #1449
Conversation
| @@ -330,7 +330,7 @@ | |||
| tuxedo-aura-15-gen1 = import ./tuxedo/aura/15/gen1; | |||
| tuxedo-infinitybook-v4 = import ./tuxedo/infinitybook/v4; | |||
| tuxedo-infinitybook-pro14-gen7 = import ./tuxedo/infinitybook/pro14/gen7; | |||
| tuxedo-infinitybook-pro14-gen9-intel = import ./tuxedo/infinitybook/pro14/gen9-intel; | |||
There was a problem hiding this comment.
If we want to rename this, we need to leave a deprecation warning in the old module because non-flake users will otherwise get an import error.
Here is an example:
https://github.com/NixOS/nixos-hardware/blob/master/common/pc/hdd/default.nix
There was a problem hiding this comment.
Would using lib.mkRenamedOptionModule in the old module be a better option?
There was a problem hiding this comment.
Not sure this applies here. We want to deprecate a file rather than a NixOS option.
There was a problem hiding this comment.
Okay. I added a deprecation warning and import to the new module to ensure that nothing breaks for the time being 😄
j0hax
force-pushed
the
tuxedo-infinitybook-maintenance
branch
from
9ecdceb to
496c55e
Compare
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f16e0cd |
Description of changes
This commit adds the Motorcomm YT6801 module for the InfinityBook Pro 14 Gen 9. Because both the Intel and AMD variants of the laptop have this Ethernet controller, the existing Nix module for the Intel variant was moved to its own directory.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input