Skip to content

dell-precision-3490: init module #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Conversation

bmrips
Copy link
Contributor

@bmrips bmrips commented Apr 24, 2025

Description of changes

Add a module for the Dell Precision 3490.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

@bmrips bmrips force-pushed the dell-precision-3490 branch from 4fe34e8 to 39400b4 Compare April 24, 2025 22:47
flake.nix Outdated
@@ -80,6 +80,7 @@
dell-latitude-e7240 = import ./dell/latitude/e7240;
dell-optiplex-3050 = import ./dell/optiplex/3050;
dell-poweredge-r7515 = import ./dell/poweredge/r7515;
dell-precision-3490 = import ./dell/precision/3490.nix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add this to the table in the README.

Copy link
Contributor Author

@bmrips bmrips Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I forgot that one. Fixed now.

@bmrips bmrips force-pushed the dell-precision-3490 branch from 39400b4 to 83315e3 Compare April 29, 2025 08:08
@bmrips bmrips force-pushed the dell-precision-3490 branch from 83315e3 to 347d4e9 Compare April 29, 2025 08:12
@Mic92
Copy link
Member

Mic92 commented Apr 29, 2025

@mergify queue

Copy link
Contributor

mergify bot commented Apr 29, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 72081c9

mergify bot added a commit that referenced this pull request Apr 29, 2025
@mergify mergify bot merged commit 72081c9 into NixOS:master Apr 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants