microsoft/surface: add patch to handle newer rust versions#1690
microsoft/surface: add patch to handle newer rust versions#16908bitbuddhist wants to merge 5 commits intoNixOS:masterfrom
Conversation
|
Can also confirm on the Surface Go running kernel 6.15.9 |
|
I've set my input like so, output from `nix log`If I set Didn't get a chance to boot yet, let me know if I'm doing something wrong as I'm fairly new to nix. |
Please try |
I think I'm getting same error but here is the output just in case: output from `nix log` |
|
same problem with surface 5 and kernel 6.12 |
This reverts commit ff87202.
|
Edit: I got it to build by just disabling Rust altogether. Probably not the most elegant solution, but it does build 😅 Hey all, thanks for the reports. To be honest, I have no idea how to address this for 6.12, but I'll do what I can to get it building before I mark this as ready. If anyone has any suggestions, please let me know! |
2ae8fda to
f7de836
Compare
f7de836 to
e580e56
Compare
I am now able to compile both |
|
What exactly is still missing here to be added to the master? |
AFAIK, just someone with write access to master |
|
Can also confirm this working on the Surface Pro 9 running kernel 6.12.19 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/linux-surface-kernel-stuck-at-6-12-19/73891/5 |
|
Hey, Thank you for this fix! Is there a clear way to get the person with write access to take a look on this and merge? Can we help in some way? |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Hi all, I'm going to close this PR as I combined these changes into PR #1696. That PR also includes the updates to the LTS and stable kernels, so you should use that until it gets merged. Sorry for any headaches this might cause! |
Description of changes
NOTE: The updates in this PR have been merged into #1696. Please use that branch instead of this one as it includes newer kernel versions. Thanks!
Adds a patch for older kernel versions so they can build using Rust 1.91, which is used in NixOS 25.11. This fixes a build error and #1685.
Update: Due to a cryptic build error, Rust is disabled for the 6.12 (
longterm) kernel. It can be re-enabled for the next LTS kernel (6.18).Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input