Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvscode-server: 1.73.1 -> 1.74.3 #214314

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Conversation

shadaj
Copy link
Contributor

@shadaj shadaj commented Feb 3, 2023

Description of changes

Update openvscode-server to latest release

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@NickCao
Copy link
Member

NickCao commented Feb 3, 2023

openvscode-server is currently the only consumer of nodejs-16_x-openssl_1_1, may you check if we can migrate away from it. See #210452

@shadaj
Copy link
Contributor Author

shadaj commented Feb 3, 2023

@NickCao fixed!

@NickCao NickCao merged commit e2b4c79 into NixOS:master Feb 4, 2023
@shadaj shadaj deleted the bump-openvscode branch February 4, 2023 05:33
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

Successfully created backport PR for release-22.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants