rubyPackages/sass-embedded: init at 1.62.1 #233655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misterio77
force-pushed
the
ruby-package-sass-embedded
branch
from
883386d to
d50d6a2
Compare
Misterio77
changed the title
ofborg
bot
added
8.has: package (new)
AndersonTorres
suggested changes
May 27, 2023
marsam
suggested changes
May 27, 2023
Misterio77
force-pushed
the
ruby-package-sass-embedded
branch
from
d50d6a2 to
b1aed53
Compare
This gem attempts to download dart-sass-embedded at build time, and that does not work with Nix. Patch it to find nixpkgs-provided dart-sass-embedded.
Misterio77
force-pushed
the
ruby-package-sass-embedded
branch
from
b1aed53 to
39c3a17
Compare
ofborg
bot
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
labels
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
amiryal
reviewed
Oct 18, 2024
| @@ -697,6 +697,16 @@ in | |||
| buildFlags = [ "--disable-lto" ]; | |||
| }); | |||
|
|
|||
| sass-embedded = _attrs: { | |||
There was a problem hiding this comment.
@AndersonTorres Re: #233655 (comment):
Hm… but throughout the rest of the same file (and throughout the rest of nixpkgs, AFAIK) this convention is not held. I would suggest to align with the prevailing custom and revert it back to attrs (no underscore).
Comment on lines
+702
to
+707
| # Skip sass_embedded step, replace exe path with nixpkgs' dart-sass-embedded | ||
| postPatch = '' | ||
| substituteInPlace ext/sass/Rakefile \ | ||
| --replace "'embedded.rb' => %w[sass_embedded] " "'embedded.rb'" \ | ||
| --replace "sass_embedded/dart-sass-embedded" "${dart-sass-embedded}/bin/dart-sass-embedded" | ||
| ''; |
There was a problem hiding this comment.
In later versions of the gem, these strings no longer appear. This PR really is stale and should be closed.
stale
bot
removed
2.status: stale
wegank
added
the
2.status: stale
|
Closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gem is part of Jekyll's default dependency tree, meaning that newly locked bundix-managed jekyll projects will use it (and eventually
rubyPackages.jekyllwill probably, too, at some point).It, however, will fail to build under nix, as its build step tries to fetch dart-sass-embedded from the internet. This PR adds
rubyPackages.sass-embeddedto nixpkgs and patches it to use nixpkgs'dart-sass-embedded, fixing the build.Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)