Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncthing: 1.27.2 -> 1.27.4 #293427

Merged
merged 1 commit into from
Mar 17, 2024
Merged

syncthing: 1.27.2 -> 1.27.4 #293427

merged 1 commit into from
Mar 17, 2024

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Mar 5, 2024

Signed-off-by: Muhammad Falak R Wani [email protected]

Description of changes

Diff: syncthing/syncthing@v1.27.2...v1.27.4
Changelog: https://github.com/syncthing/syncthing/releases/tag/v1.27.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

drupol
drupol previously requested changes Mar 5, 2024
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like build is broken on darwin

@SaltyKitkat
Copy link
Contributor

It reports

error: a 'x86_64-linux' with features {} is required to build '/nix/store/g3w73yc0j2xij8wfr1lwvwddrcv8dx4h-append-initrd-secrets.drv', but I am a 'x86_64-darwin' with features {benchmark, big-parallel, nixos-test}

I have no idea why this is requiring append-initrd-secrets.drv on darwin. Is there anything wrong in this package? Or in somewhere else?

@drupol
Copy link
Contributor

drupol commented Mar 13, 2024

@NixOS/darwin-maintainers Can you give us a hint in here?

@n8henrie
Copy link
Contributor

FWIW this seems fine locally on aarch64-darwin (x86_64-darwin also builds).

Looks like the passthru tests are all that is failing in ofborg and they are nixosTests which won't build darwin (right? -- #294725)

@wegank
Copy link
Member

wegank commented Mar 13, 2024

@ofborg build syncthing

@n8henrie
Copy link
Contributor

Interesting.

Looks like the passthru tests for aarch64-darwin passed on the most recent update, and nothing but the source / hash has changed in the derivation since then.

@wegank
Copy link
Member

wegank commented Mar 14, 2024

Yeah, someone added macOS support for NixOS tests two weeks ago, but it won't work without a Linux builder...

@marsam marsam dismissed drupol’s stale review March 17, 2024 00:14

I built it on Darwin. The error seems to be that Ofborg is trying to execute the test on Darwin

@marsam marsam merged commit 7319659 into NixOS:master Mar 17, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants