-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syncthing: 1.27.2 -> 1.27.4 #293427
syncthing: 1.27.2 -> 1.27.4 #293427
Conversation
Diff: syncthing/syncthing@v1.27.2...v1.27.4 Changelog: https://github.com/syncthing/syncthing/releases/tag/v1.27.4 Signed-off-by: Muhammad Falak R Wani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like build is broken on darwin
It reports
I have no idea why this is requiring |
@NixOS/darwin-maintainers Can you give us a hint in here? |
FWIW this seems fine locally on aarch64-darwin (x86_64-darwin also builds). Looks like the passthru tests are all that is failing in ofborg and they are nixosTests which won't build darwin (right? -- #294725) |
@ofborg build syncthing |
Interesting. Looks like the passthru tests for aarch64-darwin passed on the most recent update, and nothing but the source / hash has changed in the derivation since then. |
Yeah, someone added macOS support for NixOS tests two weeks ago, but it won't work without a Linux builder... |
I built it on Darwin. The error seems to be that Ofborg is trying to execute the test on Darwin
Signed-off-by: Muhammad Falak R Wani [email protected]
Description of changes
Diff: syncthing/syncthing@v1.27.2...v1.27.4
Changelog: https://github.com/syncthing/syncthing/releases/tag/v1.27.4
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.