-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shadps4: init at 0.3.0-unstable-2024-10-13 #340215
Conversation
1b28036
to
f58c9bc
Compare
f58c9bc
to
f93438e
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4554 |
Have you been able to launch anything with this? For me the GUI launches and I can adjust settings & install homebrew pkgs, but it just freezes & eventually segfaults on everything eboot I try to launch. |
I haven't got around to it yet, but this might just be an issue with shadPS4 itself. |
I've got a later commit building & working on some OpenOrbis samples, though there are some leftover warnings at configure time - unpackaged dependencies, and outdated/borked provided dependencies. I think we should resolve those issues first before getting this in. |
Seems like #331649 exists for toml11, but zydis v5.0.0 doesn't exist 🤔 and not sure about vulkan memory allocator |
f93438e
to
11a92a9
Compare
11a92a9
to
98c82b8
Compare
Our
|
Just syncing some info: 0.3.0 is released :) |
98c82b8
to
fdb105d
Compare
Tested this by building it myself, it seems to crash and exit without explanation unexpectedly when attempting to load a game which runs on the official build (CUSA01113) |
Could you send the logs here? I'm still waiting on SDL3 to be added |
The logs don't say very much as it's a segfault
|
shadps4-emu/shadPS4#1042 has been merged so that first patch can be removed. For Bloodborne specifically you probably want to include shadps4-emu/shadPS4#1146, but shadps4 development is happening so quickly that it might make more sense not to include any patches with this derivation and let people use (at least until things get more stable) |
Prolly needs smth like this: nixpkgs/pkgs/development/libraries/SDL2/default.nix Lines 206 to 218 in d78d093
...but for |
Yep, I was just testing using a wrapper script as it didn't require recompilation, but you can just patch the rpaty in the binary. See my edited comment. |
I've uploaded my changes at master...expenses:nixpkgs:shadps4. I'm using a local path for the shadps4 source but that's only because I'm on a bad internet connection and it cuts off before I can clone the repo in nix. I'm using the latest head (shadps4-emu/shadPS4@bf3e43b). |
Things look good now :) |
I just want to say that it seems working. |
The emulator crashed when clicking play, but it may not be due to the PR since the appimage also crashes. The errors show that the emulator doesn't support certain thread settings, has some missing functions, and can't fully access the game files. shadps4-emu/shadPS4#1311 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working well and as expected
perhaps we wish to discuss the release/update cadence here as well
I see we've now switched to unstable versions but how will we maintain which version we track, is it just the maintainer who updates the tracked commit whenever they feel like it?
I'm depending on the unstable releases for now, until stable 0.3.1 is released. |
We can always depend on latest release. For bleeding edge there is always https://github.com/chaotic-cx/nyx repo where bot automatically updates to the latest git commit. |
If you want, you can add an update script. passthru.updateScript = unstableGitUpdater {
tagPrefix = "v";
}; Should make it trivial for anyone to make a bump ( (I'll give this another review later today, not on an x86_64 machine right now) |
New auto-updater doesn't make sense for our purposes & might confuse users with it non-functionality on NixOS: shadps4-emu/shadPS4#1368 Patch to neutralise it for now: 0001-Disable-update-checking.patch.txt (didn't wanna dig deeper into how to make Qt not get stuck on weirdly initiated windows on app shutdown, otherwise I'd make it throw a warning & immediately exit here instead of hijacking that dialogue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing I've spotted, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 340215
run on x86_64-linux 1
1 package built:
- shadps4
Builds on OfBorg, OpenOrbis sample package still works, can't spot anything immediately wrong with it anymore. LGTM!
Description of changes
Adds shadPS4, an in-early development PS4 emulator.
Closes #339617
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.