catalyst-browser: init at 3.9.4 #350552
Merged
catalyst-browser: init at 3.9.4 #350552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying to format the file with the format tool and it's not doing anything. I am in the directory of the package.nix file |
ofborg
bot
added
8.has: package (new)
|
You need to go to the Nixpkgs root directory, run |
FliegendeWurst
added
the
12. first-time contribution
FliegendeWurst
requested changes
Nov 5, 2024
jdev082
force-pushed
the
init-catalyst-340
branch
2 times, most recently
from
4a766fa to
885d3e5
Compare
|
Requested changes applied and package updated to latest version. |
FliegendeWurst
approved these changes
Nov 6, 2024
FliegendeWurst
added
the
12.approvals: 1
|
This pull request is ready unless there's any more requested changes. Aarch64 Darwin binaries are officially available and could be added. |
jdev082
force-pushed
the
init-catalyst-340
branch
from
4566fc8 to
178cb61
Compare
wegank
removed
the
12.approvals: 1
FliegendeWurst
requested changes
Nov 12, 2024
jdev082
force-pushed
the
init-catalyst-340
branch
from
6549d07 to
2868af5
Compare
|
All requested changes have been made. |
jdev082
force-pushed
the
init-catalyst-340
branch
from
6a46336 to
beb1b0c
Compare
|
Not ready to be merged as I'm deciding whether or not to rename this package to
The decision and changes will be made tomorrow. |
jdev082
force-pushed
the
init-catalyst-340
branch
from
cadcb12 to
ef1e0f8
Compare
|
Package rename has been completed. |
FliegendeWurst
approved these changes
Nov 17, 2024
FliegendeWurst
added
the
12.approvals: 1
|
Requested changes have been applied. |
jdev082
force-pushed
the
init-catalyst-340
branch
2 times, most recently
from
fb1194f to
7cab2ef
Compare
jdev082
force-pushed
the
init-catalyst-340
branch
from
7cab2ef to
445215f
Compare
Signed-off-by: jdev082 <[email protected]>
| src = fetchurl { | ||
| url = "https://github.com/CatalystDevOrg/Catalyst/releases/download/v${version}/catalyst-${version}.AppImage"; | ||
| hash = "sha256-6t1RAxmRc/1fAQT4Qnd42kh3cxgRZr74k8gwebTb0Ic="; | ||
| name = "catalyst-${version}.AppImage"; |
There was a problem hiding this comment.
This looks like a no-op? (the name parameter is optional)
Suppose it doesn't hurt though.
FliegendeWurst
added
the
11.by: upstream-developer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Catalyst to the package repository.
Source code is here
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.