nixos/amuled: add systemd hardening options #354517
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
|
Thanks for your contribution, please make sure your commit messages match CONTRIBUTING.md. |
someone-stole-my-name
force-pushed
the
cs/amule-part-1
branch
from
dcffdbd to
02c8bea
Compare
Drops the script startup method in favor of directly executing the service under its own user, and adds general hardening to the systemd unit.
someone-stole-my-name
changed the title
someone-stole-my-name
force-pushed
the
cs/amule-part-1
branch
from
02c8bea to
7f8e017
Compare
|
Thanks for the review @xanderio, I just squashed and edited the commit message, please take a look again. |
Scrumplex
reviewed
Jan 5, 2025
Scrumplex
approved these changes
Jan 6, 2025
wegank
added
the
12.approvals: 1
xanderio
approved these changes
Jan 6, 2025
| @@ -61,20 +63,46 @@ in | |||
| gid = config.ids.gids.amule; | |||
| } ]; | |||
|
|
|||
| systemd.tmpfiles.rules = [ | |||
There was a problem hiding this comment.
Could you maybe use the new systemd.tmpfiles.settings interface?
There was a problem hiding this comment.
Hey, thanks for the new review. I wasn't aware of this new interface, added in c331196.
| environment.HOME = cfg.dataDir; | ||
|
|
||
| serviceConfig = { | ||
| Type = "forking"; |
There was a problem hiding this comment.
Is there a reason where using a forking service here, instead of dropping the --full-deamon arg below and letting systemd handle the rest?
There was a problem hiding this comment.
Just tested, and it works fine without it, changed in b055531, thanks.
Drop the full-deamon flag, and remove the needless forking
wegank
removed
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops the script startup method in favor of directly executing the service under its own user and adds general hardening to the systemd unit.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.