dwarf-fortress: 50.13 -> 51.05; dwarf-therapist: 42.1.6 -> 42.1.9 #356659
+419
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
numinit
force-pushed
the
dwarf-fortress-50.14
branch
from
70c83c9 to
74468a9
Compare
numinit
commented
Nov 18, 2024
numinit
force-pushed
the
dwarf-fortress-50.14
branch
from
74468a9 to
0457aa1
Compare
numinit
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5077 |
numinit
force-pushed
the
dwarf-fortress-50.14
branch
from
f457a9a to
02a537c
Compare
|
|
Thanks for the review. Should be easy to add the new Adventure Mode version in a separate PR. |
From Dwarf Therapist 42.1.7 onward, dfhack-generated memory maps work in place of Therapist's builtin memory maps. Allow this to happen. Fix some bugs with the wrapper scripts.
numinit
changed the title
numinit
force-pushed
the
dwarf-fortress-50.14
branch
from
02a537c to
cc7fb43
Compare
|
Updated to add Adventure Mode support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Dwarf Therapist 42.1.7 onward, dfhack-generated memory maps work in place of Therapist's builtin memory maps. Allow this to happen so we don't have to wait for Dwarf Therapist to update in order to update Dwarf Fortress and dfhack.
Fix some bugs with the wrapper scripts.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.