Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewatch: init at 1.0.9 #364886

Merged
merged 1 commit into from
Dec 15, 2024
Merged

rewatch: init at 1.0.9 #364886

merged 1 commit into from
Dec 15, 2024

Conversation

r17x
Copy link
Member

@r17x r17x commented Dec 13, 2024

I make this PR for support ReScript Community and accessible to use rewatch compiler with Nix environment.

see release: https://github.com/rescript-lang/rewatch/releases/tag/v1.0.9

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Tested binary functionality

❯ ./result/bin/rewatch -V
rewatch 1.0.9

Add a 👍 reaction to pull requests you find important.

@r17x r17x added 8.has: package (new) This PR adds a new package 11.by: nixpkgs-member labels Dec 13, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 13, 2024
@r17x r17x force-pushed the add/rewatch branch 2 times, most recently from 4dd9cf2 to d7677f7 Compare December 13, 2024 18:18
@r17x
Copy link
Member Author

r17x commented Dec 13, 2024

Thank you @aucub - I have been update yet, based on your suggestions.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 13, 2024
@r17x
Copy link
Member Author

r17x commented Dec 13, 2024

I have been moved to by-name/re @aucub

@r17x r17x requested a review from a user December 13, 2024 19:07
@r17x r17x requested a review from a user December 13, 2024 19:41
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 14, 2024
@r17x
Copy link
Member Author

r17x commented Dec 14, 2024

I have been added apple-sdk for building in darwin and fixed build for x86_64-darwin @aucub

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 15, 2024
@Aleksanaa Aleksanaa merged commit bc4f212 into NixOS:master Dec 15, 2024
43 of 44 checks passed
@r17x r17x deleted the add/rewatch branch December 15, 2024 14:02
@r17x r17x restored the add/rewatch branch December 16, 2024 12:07
@r17x r17x deleted the add/rewatch branch December 17, 2024 17:00
@ghost ghost removed their request for review December 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: nixpkgs-member 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants