Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/hadoop: fix, hadoop: 3.4.0 -> 3.4.1 #364992

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

illustris
Copy link
Contributor

@illustris illustris commented Dec 13, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Dec 13, 2024
@illustris
Copy link
Contributor Author

$ nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 27, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 27 (delta 9), reused 10 (delta 7), pack-reused 6 (from 1)
Unpacking objects: 100% (27/27), 33.74 KiB | 1.16 MiB/s, done.
From https://github.com/NixOS/nixpkgs
   ba25f1601b96..3a0de0544cc4  master     -> refs/nixpkgs-review/0
$ git worktree add /home/illustris/.cache/nixpkgs-review/rev-c62ec80d1fc0cc4a665f3dca74a4d1292a8820e5/nixpkgs 3a0de0544cc4102ef06a4dee193d4f0325b530be
Preparing worktree (detached HEAD 3a0de0544cc4)
Updating files: 100% (44911/44911), done.
HEAD is now at 3a0de0544cc4 shopware-cli: 0.4.60 -> 0.4.61 (#364899)
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/illustris/.cache/nixpkgs-review/rev-c62ec80d1fc0cc4a665f3dca74a4d1292a8820e5/nixpkgs nixpkgs-overlays=/tmp/nix-shell-1934925-0/tmpk6q_g1jc -qaP --xml
--out-path --show-trace --no-allow-import-from-derivation
$ git merge --no-commit --no-ff c62ec80d1fc0cc4a665f3dca74a4d1292a8820e5
Automatic merge went well; stopped before committing as requested
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/illustris/.cache/nixpkgs-review/rev-c62ec80d1fc0cc4a665f3dca74a4d1292a8820e5/nixpkgs nixpkgs-overlays=/tmp/nix-shell-1934925-0/tmpk6q_g1jc -qaP --xml
--out-path --show-trace --no-allow-import-from-derivation --meta
--------- Impacted packages on 'x86_64-linux' ---------
9 packages updated:
hadoop (3.4.0 → 3.4.1) nixos-install-tools pig python3.11-dask-yarn python3.11-skein python3.12-dask-yarn python3.12-skein spark spark


$ nix build --file /nix/store/fljl402absl1lsyqd9w6cslvcxa7xs0z-nixpkgs-review-2.12.0/lib/python3.12/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path 'nixpkgs=/home/illustris/.cache/nixpkgs-review/rev-c62ec80d1fc0cc4a665f3dca74a4d1292a8820e5/nixpkgs nixpkgs-overlays=/tmp/nix-shell-1934925-0/tmpk6q_g1jc' --extra-experimental-features 'nix-command no-url-literals' --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed --argstr local-system x86_64-linux --argstr nixpkgs-path /home/illustris/.cache/nixpkgs-review/rev-c62ec80d1fc0cc4a665f3dca74a4d1292a8820e5/nixpkgs --argstr nixpkgs-config-path /tmp/nix-shell-1934925-0/tmpkf_6x6bl.nix --argstr attrs-path /home/illustris/.cache/nixpkgs-review/rev-c62ec80d1fc0cc4a665f3dca74a4d1292a8820e5/attrs.nix
--------- Report for 'x86_64-linux' ---------
1 package blacklisted:
nixos-install-tools

12 packages built:
hadoop pig python311Packages.dask-yarn python311Packages.dask-yarn.dist python311Packages.skein python311Packages.skein.dist python312Packages.dask-yarn python312Packages.dask-yarn.dist python312Packages.skein python312Packages.skein.dist spark spark_3_4


$ /nix/store/nmpx2d5vlypzbc62rzcbplyaygxq6kk6-nix-2.24.10/bin/nix-shell --argstr local-system x86_64-linux --argstr nixpkgs-path /home/illustris/.cache/nixpkgs-review/rev-c62ec80d1fc0cc4a665f3dca74a4d1292a8820e5/nixpkgs --argstr nixpkgs-config-path /tmp/nix-shell-1934925-0/tmpkf_6x6bl.nix --argstr attrs-path /home/illustris/.cache/nixpkgs-review/rev-c62ec80d1fc0cc4a665f3dca74a4d1292a8820e5/attrs.nix --nix-path 'nixpkgs=/home/illustris/.cache/nixpkgs-review/rev-c62ec80d1fc0cc4a665f3dca74a4d1292a8820e5/nixpkgs nixpkgs-overlays=/tmp/nix-shell-1934925-0/tmpk6q_g1jc' /nix/store/fljl402absl1lsyqd9w6cslvcxa7xs0z-nixpkgs-review-2.12.0/lib/python3.12/site-packages/nixpkgs_review/nix/review-shell.nix

@illustris illustris marked this pull request as ready for review December 14, 2024 06:40
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 14, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4957

@SuperSandro2000 SuperSandro2000 merged commit 12c53e4 into NixOS:master Dec 17, 2024
61 of 62 checks passed
@illustris illustris deleted the hadoop-fix branch December 18, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants