shadow-launcher: init at 9.9.10132 #365034
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
| xorg.libXdmcp | ||
| ]; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
with lib is deprecated #208242
There was a problem hiding this comment.
Good to know, I wasn't aware of that. FIxed
| meta = with lib; { | ||
| description = "Cloud Gaming Platform"; | ||
| longDescription = '' | ||
| Experience the power of cloud gaming with Shadow.tech. |
There was a problem hiding this comment.
This reads a lot like marketing copy, and isn't particularly clear. Could the description be lengthened with a bit more detail, and then the long description dropped?
There was a problem hiding this comment.
Yeah, I copied the description from their website. Changed
| pname = "shadow-launcher"; | ||
| version = "9.9.10132"; | ||
| src = fetchurl { | ||
| url = "https://update.shadow.tech/launcher/prod/linux/ubuntu_18.04/ShadowPC.AppImage"; |
There was a problem hiding this comment.
Do they offer versioned URLs? This looks like a URL that will change over time. When that happens the hash will break and it will be unusable. If they update multiple times a year, then it is likely to be broken most the time in the stable nixpkgs release
There was a problem hiding this comment.
Unfortunately no, at least not to my knowledge. They provide only prod and beta channels, which always contain the latest version of the app. However, I’ll check their Discord to confirm.
There was a problem hiding this comment.
Thanks, it would be unfortunate if this derivation were to be permanently broken in nixpkgs releases
There was a problem hiding this comment.
Changed to use url with defined version
There was a problem hiding this comment.
Ah, that is great, thanks for sorting that with them!
jakub-pravda
force-pushed
the
shadow-pc
branch
from
18682dc to
81c7018
Compare
ofborg
bot
added
8.has: package (new)
jakub-pravda
force-pushed
the
shadow-pc
branch
from
81c7018 to
b08715e
Compare
jakub-pravda
force-pushed
the
shadow-pc
branch
from
b08715e to
5ce45e6
Compare
jakub-pravda
changed the title
jakub-pravda
force-pushed
the
shadow-pc
branch
from
5ce45e6 to
a195de7
Compare
There was a problem hiding this comment.
I don't have commit access, and don't maintain a similar package, so it doesn't make sense for me to leave an approving review. However I wouldn't want to block the PR in any way
My suggestion would be to find someone who has merged a similar package into nixpkgs recently, and request a review from them
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5039 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5156 |
Shadow PC Cloud Workstation is Windows Virtual PC streamed from the cloud. Install your regular software, and work flawlessly from any device connected to the Internet.
https://shadow.tech/
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)