Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harlequin: relax numpy to fix build #370802

Closed
wants to merge 1 commit into from

Conversation

GaetanLepage
Copy link
Contributor

Things done

Fixes #370797

cc @pcboy

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pcboy
Copy link
Contributor

pcboy commented Jan 4, 2025

The build will be fixed but harlequin itself will not work. We are already working on this in #365766 and #370103

As soon as Textual 1.0 is merged in, I will re-update the Harlequin MR (or maybe close and open a new one) to fix the build.

@GaetanLepage
Copy link
Contributor Author

The build will be fixed but harlequin itself will not work. We are already working on this in #365766 and #370103

As soon as Textual 1.0 is merged in, I will re-update the Harlequin MR (or maybe close and open a new one) to fix the build.

Ok great ! Closing this one then.

@GaetanLepage GaetanLepage deleted the harlequin branch January 4, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: harlequin
2 participants